Fix editData in HTML/UWP extensions allocating too much data#31
Merged
Conversation
…he cursor position (in v2)
Offset calculation was incorrect. Thanks to @AITYunivers for initial spotting. privateData stores the offset from EDITDATA start to Props start. It should skip both eHeader and any in-between variables. eHeader is 20 bytes; that's a fixed C struct, always at start of any SDK EDITDATA. However, it's not passed in with edPtrFile, as the runtime itself reads the eHeader and pushes past it. Props is DarkEdif only, varying size, and always at end of EDITDATA. DarkScript prop edits are kept, but note it's not even updated to SDK v20, or v2 prop sets yet. Bluewing prop edits kept, although Bluewing doesn't use DarkEdif smart props, doing everything manually instead. Properties there are only kept because it means no extra edits for the DarkEdif starter code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
editData is allocated using
(in v1)
(in v2)
neither of these equations account for the size of eHeader, and in v2 the header not including verStr in it's length.
This PR fixes these by subtracting eHeader and by subtracting 4 (in the Template only as the extensions are v1)